-
Notifications
You must be signed in to change notification settings - Fork 93
Compliant Policies Arguments Validation #5168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changelog(s) in markdown:
|
|
Changelog(s) in markdown:
|
Shellyber
reviewed
Jan 8, 2026
demisto_sdk/commands/validate/validators/BA_validators/BA129_missing_compliant_policies.py
Outdated
Show resolved
Hide resolved
demisto_sdk/commands/validate/validators/BA_validators/BA129_missing_compliant_policies.py
Show resolved
Hide resolved
Shellyber
approved these changes
Jan 12, 2026
Contributor
Shellyber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
yedidyacohenpalo
approved these changes
Jan 13, 2026
jbabazadeh
approved these changes
Jan 13, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: Ticket
Description
Adds a new ignorable validation (BA129) that ensures commands/scripts declare the appropriate compliantpolicies when using arguments associated with specific compliance standards (defined in compliant_policies.json).
Key Logic:
Checks if command arguments match any known policy arguments.
Verifies that the compliantpolicies field contains the required policy name.
Multi-Policy Support: If an argument is associated with multiple policies (e.g., "Soft" and "Hard" remediation), the validation passes if at least one of them is present.